Optimize SigV4 and add S3 content-sha256 handling#1217
Merged
Conversation
Switch signing to in-place strided buffers in SigningResources, removing the per-call TreeMap/ArrayList/Pair allocations and one UTF-8 encoder pass. Add x-amz-content-sha256 to the canonical request and wire request for s3/s3express; honor pre-set X-Amz-Date, security-token, and content- sha256 headers; throw on unknown-length payloads instead of signing as empty; treat port -1 as default in the Host header; fast-path the already-canonical query string. Test runner ignores Content-Length when comparing requests (signature-irrelevant; auto-derived locally).
sugmanue
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
Switch signing to in-place strided buffers in SigningResources, removing the per-call TreeMap/ArrayList/Pair allocations and one UTF-8 encoder pass. Add x-amz-content-sha256 to the canonical request and wire request for s3/s3express; honor pre-set X-Amz-Date, security-token, and content- sha256 headers; throw on unknown-length payloads instead of signing as empty; treat port -1 as default in the Host header; fast-path the already-canonical query string. Test runner ignores Content-Length when comparing requests (signature-irrelevant; auto-derived locally).
Why is this change needed?
performance, s3 compat
How was this validated?
tests, called s3
What should reviewers focus on?
Additional Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.