Add event stream protocol tests for client#1176
Open
joewyz wants to merge 1 commit into
Open
Conversation
mtdowling
reviewed
May 27, 2026
| // We dont ignore defaults on input shapes | ||
| "aws.protocoltests.restjson#OperationWithDefaults", | ||
| }, | ||
| skipTests = { |
Member
There was a problem hiding this comment.
Is this list right? We had no exclusions before and now we have a ton?
Contributor
Author
There was a problem hiding this comment.
Most of the skipped blob tests can be removed given that we released the change to update the test model. Will work on the remaining fixes later.
| for (Schema member : schema.members()) { | ||
| if (member.hasTrait(TraitKey.EVENT_HEADER_TRAIT)) { | ||
| if (member.hasTrait(TraitKey.EVENT_HEADER_TRAIT) | ||
| && headersDeserializer.headers.containsKey(member.memberName())) { |
Contributor
Author
There was a problem hiding this comment.
I added this to prevent it from reading all the members in the structure, otherwise all header input tests would fail.
example structure:
structure HeadersEvent {
@eventHeader
booleanHeader: Boolean
@eventHeader
byteHeader: Byte
@eventHeader
shortHeader: Short
@eventHeader
intHeader: Integer
@eventHeader
longHeader: Long
@eventHeader
blobHeader: Blob
@eventHeader
stringHeader: String
@eventHeader
timestampHeader: DateTime
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add event stream protocol tests for client. Will work on fixes for skipped test cases later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.