Fix Mantle deployment failures by switching to deployContract#2
Open
Nalon wants to merge 1 commit into
Open
Conversation
Replace sendDeploymentTransaction + waitForTransactionReceipt with viem.deployContract(..., { confirmations }) across all deployment tasks.
sendDeploymentTransaction calls getTransaction immediately after broadcast, which can raise TransactionNotFoundError on Mantle Sepolia before the RPC indexes the transaction. deployContract polls for the receipt instead.
Updated tasks:
- deployToken
- deployBurnMintTokenPool
- deployERC20LockBox
- deployLockReleaseTokenPool
- deployAdvancedPoolHooks
Post-deployment write transactions (e.g. role grants, authorized caller updates) are unchanged.
|
👋 Nalon, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendDeploymentTransactionwithviem.deployContract(..., { confirmations })in all five deployment tasksTransactionNotFoundErroron Mantle Sepolia, where the RPC does not index deployment transactions quickly enough for an immediategetTransactioncallpublicClientsetup where it was only needed for the old deployment wait pathAffected tasks
deployTokenCrossChainTokendeployTokenPoolBurnMintTokenPooldeployERC20LockBoxERC20LockBoxdeployLockReleaseTokenPoolLockReleaseTokenPooldeployAdvancedPoolHooksAdvancedPoolHooksAll impacted tasks are tested and functioning as expected.