grafana: change default exec err state to Error to match Grafana default#2149
Open
guerremdq wants to merge 1 commit into
Open
grafana: change default exec err state to Error to match Grafana default#2149guerremdq wants to merge 1 commit into
guerremdq wants to merge 1 commit into
Conversation
|
👋 guerremdq, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
📊 API Diff Results
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Grafana alert rule builder defaults in observability-lib so that the exec error state aligns with Grafana’s own default behavior.
Changes:
- Change the default
RuleExecErrStatefromAlertingtoErrorwhen not explicitly set inAlertOptions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
212
to
214
| if options.RuleExecErrState == "" { | ||
| options.RuleExecErrState = alerting.RuleExecErrStateAlerting | ||
| options.RuleExecErrState = alerting.RuleExecErrStateError | ||
| } |
guerremdq
force-pushed
the
grafana-alert-errstate
branch
from
75eefed to
3cb871c
Compare
Atrax1
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change default exec err state to Error to match Grafana default