Fix: Pipeline.search() missing from generated SkipBridge peer#94
Merged
marcprux merged 1 commit intoJul 3, 2026
Merged
Conversation
…bridge peer Pipeline.search(query:) carried a `// SKIP REPLACE:` comment specifying an identical-in-substance Kotlin body to what the naive Swift-to-Kotlin transpile already produces. That override causes SkipBridge to silently omit `search` from the generated Swift bridge peer (Pipeline_Bridge.swift) used by SKIP_BRIDGE-flagged consumer builds (e.g. Skip apps targeting Android), even though the Kotlin transpile output itself is correct. limit(_:), offset(_:), and whereCondition(_:) — which have no REPLACE override — bridge correctly. Consumer symptom: `swift build --swift-sdk aarch64-unknown-linux-android28 ... -DSKIP_BRIDGE` fails with "value of type 'Pipeline' has no member 'search'" despite the Kotlin side compiling fine. Removing the override lets the naive transpile (verified byte-identical Kotlin output) stand, restoring bridge visibility.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pipeline.search(query:)carried a// SKIP REPLACE:comment whose Kotlin is functionally identical to what the naive Swift→Kotlin transpile already produces.searchfrom the generated Swift bridge peer (Pipeline_Bridge.swift) used bySKIP_BRIDGE-flagged consumer builds (e.g. an app targeting Android), even though the Kotlin transpile output is correct and identical with or without the override.limit(_:),offset(_:), andwhereCondition(_:)— which have noSKIP REPLACEoverride — bridge correctly and were used to confirm the pattern.searchwhile leaving the transpiled Kotlin byte-for-byte identical (verified locally).Consumer-side symptom
Building a Skip app for Android hits:
during the
SKIP_BRIDGE-flaggedswift build --swift-sdk aarch64-unknown-linux-android28 ...pass, despiteFirestore EnterprisePipeline FTS working correctly on iOS and the Kotlin transpile compiling fine.Test plan
swift build --product SkipFirebaseFirestoresucceeds (iOS/macOS side).Pipeline.ktoutput before/after removing the override — byte-identicalsearchimplementation.SKIP_BRIDGEAndroid build in the downstream consumer app (Club-App) — in progress, will confirm once this lands.