Skip to content

fix(custom-tool): restore modal body scroll so Save stays reachable #5321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
Jul 1, 2026
+7 −5
Merged

fix(custom-tool): restore modal body scroll so Save stays reachable #5321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4908fa4
fix(custom-tool): restore modal body scroll so Save stays reachable
waleedlatif1 Jul 1, 2026
d90dde9
fix(custom-tool): keep dropdown anchors content-relative on body scroll
waleedlatif1 Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ...onents/sub-block/components/tool-input/components/custom-tool-modal/custom-tool-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,12 +832,14 @@ try {
</ChipModalHeader>

{/*
flex-none + overflow-visible opt this body out of the chrome's
scroll container: the caret-anchored EnvVar/Tag autocomplete
dropdowns are absolute-positioned inside it and must spill past
the body's bounds rather than clip against a scroll boundary.
The body is the scroll region so tall schema/code content stays inside
the modal and the footer (Next/Save) is always reachable. The EnvVar,
Tag, and schema-param autocompletes render their menus in portaled
popovers (never clipped by this scroll boundary) and anchor to a
caret-positioned element inside the editor wrapper, so the menus track
the caret as the body scrolls.
*/}
<ChipModalBody className='flex-none gap-2 overflow-visible px-4'>
<ChipModalBody className='gap-2 px-4'>
Comment thread
waleedlatif1 marked this conversation as resolved.
Comment thread
waleedlatif1 marked this conversation as resolved.
<ChipModalTabs
tabs={[
{ value: 'schema', label: 'Schema' },
Expand Down
Loading