improvement(sendblue): audit fixes — optional group numbers, seat_id, typing state/duration#5300
Conversation
… typing state/duration
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Send group message no longer requires Send message and send group message accept optional Send typing indicator gains Inbound webhook Adds Reviewed by Cursor Bugbot for commit bb4ccae. Configure here. |
Greptile SummaryThis PR updates the Sendblue integration to match the current API behavior. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (5): Last reviewed commit: "fix(sendblue): trim and drop blank group..." | Re-trigger Greptile |
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 116a0bb. Configure here.
…e empty group_id to null
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 89d3885. Configure here.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit bb4ccae. Configure here.
Summary
validate-integration+validate-triggeraudit of the Sendblue integration against the live Sendblue API docs. No critical issues — the integration was already clean; these are correctness/completeness fixes.numbersis now optional on Send Group Message (tool + block). Sendblue allows sending to an existing group viagroup_idalone, sonumbersis no longer hard-required; a cleared field is omitted from the request instead of sending[].seat_idsend param to Send Message and Send Group Message — attributes a message to a seat/user (seat UUID or Firebase Auth subject), per docs.state(start/stop) andmax_duration_ms(1–300000, default 60000) params to Send Typing Indicator, per docs.Number()coercion lives intools.config.params(nottools.config.tool), with empty/NaN guarded.media_urltonullso it matches the "if any" output semantics; aligned thegroup_idtrigger output description to the actualnullbehavior.verifyAuth: Sendblue's webhook secret header name/scheme is undocumented across all sources, so implementing verification would require guessing. Added TSDoc recording the gap and how to wire it (verifyTokenAuth/createHmacVerifier) once Sendblue documents the scheme.sendblue.mdx) to reflect the new params.Type of Change
Testing
Tested manually —
tsc --noEmitandbiome checkclean on all changed files; docs regenerated and verified scoped to Sendblue.Checklist