Skip to content

feat(forking): resource copying UX to help with setup speed#5294

Merged
icecrasher321 merged 6 commits into
stagingfrom
feat/ws-fork-pt-2
Jul 1, 2026
Merged

feat(forking): resource copying UX to help with setup speed#5294
icecrasher321 merged 6 commits into
stagingfrom
feat/ws-fork-pt-2

Conversation

@icecrasher321

@icecrasher321 icecrasher321 commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

Ability to cleanly copy and retain references to resources during fork and sync. Remains behind feature flag.

Type of Change

  • Other: UX Improvement

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 1, 2026 12:32am

Request Review

@cursor

cursor Bot commented Jun 30, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes touch fork promote/copy gates, workflow reference remapping, and deployed webhook provider config reads; mistakes could clear wrong fields or mis-route triggers, though coverage is added in tests.

Overview
Fork and sync now share folder-grouped file trees and expandable resource pickers. The fork modal defaults to copying all resources, blocks fork until resources load, and renames copyable MCP to workflow MCP servers. Sync accepts optional copyResources, shows copyable unmapped resources (map vs copy reconciliation), a reactive “Will be cleared” list, and “Copy instead” on mapping entries; required refs can be satisfied by mapping or copy.

Post-fork failures sweep draft and deployed workflow state to clear references to resources that failed to copy, with activity reporting for incomplete cleanup. Nested tool params clear transitive dependsOn fields when a parent changes, aligned with top-level blocks.

Markdown editors can disable @ tagging via disableTagging (e.g. deploy version description). Webhook deploy/polling collapses basic/advanced trigger fields to canonical keys with transitional fallbacks. Workflow ID remapping clears inputMapping when the active canonical workflow selector is cleared and improves cross-workflow remap edge cases.

Fork background-work uses assertWorkspaceAdminAccess like other fork routes.

Reviewed by Cursor Bugbot for commit 49e129b. Configure here.

Comment thread apps/sim/lib/workspaces/fork/copy/cleanup-failed.ts Outdated
@greptile-apps

greptile-apps Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR improves workspace fork and sync resource copying. The main changes are:

  • Adds selectable resource copying for fork and promote flows.
  • Copies and rewrites skill, file, table, and knowledge-base references after fork setup.
  • Adds cleanup for failed copied resources and activity metadata.
  • Updates fork resource picker UI and related API contracts.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The skill-only fork path now schedules the background copy work needed to rewrite copied skill content.

Important Files Changed

Filename Overview
apps/sim/lib/workspaces/fork/create-fork.ts The fork creation path now schedules background content copying when copied skills or documents require post-commit work.
apps/sim/lib/workspaces/fork/copy/content-copy-runner.ts The content-copy runner now uses a shared content-work check and carries serialized reference maps into the background job.
apps/sim/lib/workspaces/fork/copy/copy-resources.ts Resource container copying now tracks copied skills for later body rewriting and supports additional copied resource metadata.

Reviews (3): Last reviewed commit: "fix skill memory bounding;" | Re-trigger Greptile

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

bugbot run

Comment thread apps/sim/lib/workflows/persistence/remap-internal-ids.ts
@icecrasher321

Copy link
Copy Markdown
Collaborator Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 49e129b. Configure here.

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@greptile

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@greptile

@icecrasher321 icecrasher321 merged commit 7662ecc into staging Jul 1, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant