Skip to content

Migrate DOM-classes to PHP 8.4's new DOM-API #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tvdijen wants to merge 1 commit into
base: release-2.x
Choose a base branch
from
Open

Migrate DOM-classes to PHP 8.4's new DOM-API #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/SPID/XML/saml/Issuer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace SimpleSAML\SPID\XML\saml;

use DOMElement;
use Dom;
use SimpleSAML\Assert\Assert;
use SimpleSAML\SAML2\Constants as C;
use SimpleSAML\SAML2\Type\SAMLAnyURIValue;
Expand Down Expand Up @@ -36,12 +36,12 @@ public function __construct(
/**
* Convert XML into an Issuer
*
* @param \DOMElement $xml The XML element we should load
* @param \Dom\Element $xml The XML element we should load
*
* @return static
* @throws \SimpleSAML\XMLSchema\Exception\InvalidDOMElementException
*/
public static function fromXML(DOMElement $xml): static
public static function fromXML(Dom\Element $xml): static
{
Assert::same($xml->localName, 'Issuer', InvalidDOMElementException::class);
Assert::same($xml->namespaceURI, Issuer::NS, InvalidDOMElementException::class);
Expand Down
Loading