fix(cli): avoid transform() when table missing (header-only CSV + detect-types)#730
Open
beejak wants to merge 1 commit intosimonw:mainfrom
Open
fix(cli): avoid transform() when table missing (header-only CSV + detect-types)#730beejak wants to merge 1 commit intosimonw:mainfrom
beejak wants to merge 1 commit intosimonw:mainfrom
Conversation
simonw#702) insert_upsert_implementation and memory multi-file import call Table.transform() after TypeTracker runs. For a CSV with only a header row, insert_all yields no rows and may not create the table; transform() then asserted. Only run transform when the table exists. Covers both the insert command path and the memory command path. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #702.
When importing CSV with default
--detect-types, a header-only file (no data rows) yields an empty insert. The table may not exist yet, but the CLI still calledTable.transform()from the type tracker path, which asserts that the table exists.Guard both code paths with
db[table].exists()before callingtransform():insert_upsert_implementation(e.g.sqlite-utils insert ... --csv)memorycommand path that uses the same tracker +insert_all+transformsequenceTest
Added
test_insert_csv_header_only_detect_types_no_crash: header-only CSV + default detection exits 0 and does not create a table (same net behavior as before for zero rows, without crashing).Verification
📚 Documentation preview 📚: https://sqlite-utils--730.org.readthedocs.build/en/730/