Skip to content

Update SMT retirement notice to include a date#3958

Merged
RaymondLuong3 merged 1 commit into
masterfrom
feature/update-smt-retirement-notice
Jun 19, 2026
Merged

Update SMT retirement notice to include a date#3958
RaymondLuong3 merged 1 commit into
masterfrom
feature/update-smt-retirement-notice

Conversation

@Nateowami

@Nateowami Nateowami commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Before

localhost_5000_projects_6a2068103a3af1fd8b2b22ec_translate_DEU_1 (2)

After

localhost_5000_projects_6a2068103a3af1fd8b2b22ec_translate_DEU_1 (1)

Changes

  • More scary (we haven't gotten messages as a result of the existing notice)
  • Clearer message ("removed" instead of "retired")
  • Email link
  • Date specified

Disabling SMT can be done on a per-project basis, which will automatically make the message disappear.


This change is Reviewable

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.92%. Comparing base (474dc16) to head (de9e611).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3958   +/-   ##
=======================================
  Coverage   80.91%   80.92%           
=======================================
  Files         636      637    +1     
  Lines       41240    41245    +5     
  Branches     6724     6702   -22     
=======================================
+ Hits        33371    33376    +5     
- Misses       6814     6827   +13     
+ Partials     1055     1042   -13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami force-pushed the feature/update-smt-retirement-notice branch from ee8d004 to de9e611 Compare June 19, 2026 19:53
@Nateowami Nateowami deployed to screenshot_diff June 19, 2026 20:00 — with GitHub Actions Active

@RaymondLuong3 RaymondLuong3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. We have to make sure that the changes in the .json files are merged and released together with this change.

@RaymondLuong3 reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

@RaymondLuong3 RaymondLuong3 merged commit 8bc2c34 into master Jun 19, 2026
29 checks passed
@RaymondLuong3 RaymondLuong3 deleted the feature/update-smt-retirement-notice branch June 19, 2026 20:23
@Nateowami

Copy link
Copy Markdown
Collaborator Author

@RaymondLuong3 It's a new i18n key so it will just fall back to English.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants