Skip to content

SF-3815 Inform Bugsnag which exceptions are handled#3948

Merged
RaymondLuong3 merged 3 commits into
masterfrom
fix/SF-3815
Jun 18, 2026
Merged

SF-3815 Inform Bugsnag which exceptions are handled#3948
RaymondLuong3 merged 3 commits into
masterfrom
fix/SF-3815

Conversation

@pmachapman

@pmachapman pmachapman commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

I found it impossible to test this locally - even when I set the NotifyReleaseStages to include "development", no exception was reported to bugsnag.

I think the best place to test this PR is on QA.


This change is Reviewable

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.66667% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.87%. Comparing base (e4b4320) to head (4817833).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rc/SIL.XForge/ExceptionLogging/ExceptionHandler.cs 42.85% 8 Missing ⚠️
...ntApp/src/xforge-common/error-reporting.service.ts 50.00% 3 Missing ⚠️
...pp/src/xforge-common/exception-handling.service.ts 40.00% 3 Missing ⚠️
src/SIL.XForge/Realtime/MemoryExceptionHandler.cs 0.00% 2 Missing ⚠️
...rge/Services/JsonRpcServiceCollectionExtensions.cs 0.00% 2 Missing ⚠️
src/SIL.XForge.Scripture/Startup.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3948      +/-   ##
==========================================
- Coverage   80.88%   80.87%   -0.01%     
==========================================
  Files         635      635              
  Lines       41076    41081       +5     
  Branches     6693     6672      -21     
==========================================
  Hits        33223    33223              
- Misses       6815     6819       +4     
- Partials     1038     1039       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember the same thing when I wanted to see error reports on bugsnag from dev, but I couldn't shake it to do that. I wonder if bugsnag is filtering out dev reports and we just aren't seeing them there.
Let's get this to QA and we can test how errors are reported there.

@RaymondLuong3 reviewed 10 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@RaymondLuong3 RaymondLuong3 merged commit 14080cb into master Jun 18, 2026
26 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/SF-3815 branch June 18, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants