Skip to content

SF-3332 Prevent user from deleting footnotes#3915

Draft
RaymondLuong3 wants to merge 1 commit into
masterfrom
fix/sf-3332-footnote-delete
Draft

SF-3332 Prevent user from deleting footnotes#3915
RaymondLuong3 wants to merge 1 commit into
masterfrom
fix/sf-3332-footnote-delete

Conversation

@RaymondLuong3

@RaymondLuong3 RaymondLuong3 commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Users were previously allowed to make a selection that included a cross reference or footnote. We do not want to allow users to select these notes which they would then be able to overwrite or delete. This PR introduces logic to identify notes contained in a collection and update the selection be come before the notes.


This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label May 29, 2026
@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4859 1 4858 3
View the top 1 failed test(s) by shortest run time
.EditorComponent Translation Suggestions enabled::EditorComponent Translation Suggestions enabled select non-blank segment
Stack Traces | 0.197s run time
Error: Expected true to be false.
    at <Jasmine>
    at UserContext.<anonymous> (.../translate/editor/editor.component.spec.ts:457:45)
    at UserContext.fakeAsyncFn (node_modules/zone.js/fesm2015/zone-testing.js:1715:26)
    at _ZoneDelegate.invoke (node_modules/zone.js/fesm2015/zone.js:398:28)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@RaymondLuong3 RaymondLuong3 marked this pull request as draft May 29, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant