Skip to content

Refactor WordAlignment as vertical slice#963

Merged
Enkidu93 merged 7 commits into
mainfrom
word-alignment-vertical-slice
Jun 12, 2026
Merged

Refactor WordAlignment as vertical slice#963
Enkidu93 merged 7 commits into
mainfrom
word-alignment-vertical-slice

Conversation

@Enkidu93

@Enkidu93 Enkidu93 commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Fixes #919

Also, added missing Translation tests


This change is Reviewable

@codecov-commenter

codecov-commenter commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.87902% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.93%. Comparing base (82456c4) to head (9bd1c17).

Files with missing lines Patch % Lines
...erval.WordAlignment/Features/Engines/StartBuild.cs 89.08% 21 Missing and 4 partials ⚠️
...rc/Serval.WordAlignment/Services/ContractMapper.cs 87.27% 17 Missing and 4 partials ⚠️
...Alignment/Features/Engines/UpdateParallelCorpus.cs 82.90% 16 Missing and 4 partials ⚠️
...val/src/Serval.WordAlignment/Services/DtoMapper.cs 94.21% 8 Missing and 2 partials ⚠️
...ordAlignment/Features/Engines/AddParallelCorpus.cs 94.59% 2 Missing and 2 partials ⚠️
...ment/Features/Engines/BuildRepositoryExtensions.cs 85.71% 1 Missing and 2 partials ⚠️
.../Serval.WordAlignment/Features/Engines/GetBuild.cs 92.30% 1 Missing and 2 partials ⚠️
...rval.WordAlignment/Features/Engines/CancelBuild.cs 94.87% 1 Missing and 1 partial ⚠️
...val.WordAlignment/Features/Engines/DeleteEngine.cs 93.33% 1 Missing and 1 partial ⚠️
...Alignment/Features/Engines/DeleteParallelCorpus.cs 97.22% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
+ Coverage   65.54%   65.93%   +0.39%     
==========================================
  Files         381      390       +9     
  Lines       21798    21992     +194     
  Branches     2782     2786       +4     
==========================================
+ Hits        14288    14501     +213     
+ Misses       6461     6442      -19     
  Partials     1049     1049              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Enkidu93 Enkidu93 requested a review from ddaspit June 11, 2026 20:59

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit partially reviewed 46 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

@Enkidu93 Enkidu93 force-pushed the word-alignment-vertical-slice branch from aeccd82 to 9bd1c17 Compare June 12, 2026 15:06
@Enkidu93 Enkidu93 merged commit 41e6185 into main Jun 12, 2026
1 of 2 checks passed
@Enkidu93 Enkidu93 deleted the word-alignment-vertical-slice branch June 12, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move all alignment engine endpoints to vertical slices

3 participants