Skip to content

Add e2e test that opens the Interlinearizer#116

Merged
imnasnainaec merged 3 commits into
mainfrom
e2e-open-ext
Jun 19, 2026
Merged

Add e2e test that opens the Interlinearizer#116
imnasnainaec merged 3 commits into
mainfrom
e2e-open-ext

Conversation

@imnasnainaec

@imnasnainaec imnasnainaec commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Resolves #115.

Adds an openInterlinearizerFromScriptureEditor helper to e2e-tests/fixtures/helpers.ts as the shared prerequisite stage for all future e2e tests that require the Interlinearizer to be open, and a smoke test that exercises the full open flow and verifies the Interlinearizer's ≡ and ⚙ menu buttons are both clickable.

Devin: https://app.devin.ai/review/sillsdev/interlinearizer-extension/pull/116


This change is Reviewable

Summary by CodeRabbit

  • Tests
    • Added comprehensive automated test coverage for the Interlinearizer opening workflow from Scripture Editor
    • Enhanced test infrastructure with new test utilities validating Interlinearizer functionality and UI interactions

Resolves #115. Adds an openInterlinearizerFromScriptureEditor helper
to e2e-tests/fixtures/helpers.ts as the shared prerequisite stage for
all future e2e tests that require the Interlinearizer to be open, and
a smoke test that exercises the full open flow and verifies the
Interlinearizer's ≡ and ⚙ menu buttons are both clickable.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@imnasnainaec imnasnainaec self-assigned this Jun 19, 2026
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@imnasnainaec, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 40 minutes and 33 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4eb188ec-062f-46f0-ab79-94f65300ba15

📥 Commits

Reviewing files that changed from the base of the PR and between 6b93e8d and 3510959.

📒 Files selected for processing (2)
  • AGENTS.md
  • e2e-tests/fixtures/helpers.ts
📝 Walkthrough

Walkthrough

Adds a reusable Playwright helper openInterlinearizerFromScriptureEditor to e2e-tests/fixtures/helpers.ts that navigates the Platform.Bible UI to open the Interlinearizer from the Scripture Editor. A new smoke test spec exercises this helper and verifies the Interlinearizer iframe's Project menu and View options panel. The existing extension-launch suite and test case names are also updated.

Changes

Open Interlinearizer e2e helper and smoke test

Layer / File(s) Summary
openInterlinearizerFromScriptureEditor helper
e2e-tests/fixtures/helpers.ts
Adds expect import and a new exported async helper that focuses the Scripture Editor dock tab, navigates the iframe Project menu to "Open Interlinearizer for this Project", selects the requested project from the picker dialog (using escaped regex), then waits for and focuses the Interlinearizer dock tab.
Open Interlinearizer smoke test and suite rename
e2e-tests/tests/smoke/open-interlinearizer.spec.ts, e2e-tests/tests/smoke/extension-launch.spec.ts
Adds a new smoke spec that calls the helper and verifies the Interlinearizer iframe's Project (≡) menu open/close behavior and View options (⚙) panel rendering. Renames the extension-launch suite from "Interlinearizer Extension Smoke Tests" to "Launch app and register Interlinearizer" and updates the test case capitalization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • alex-rawlings-yyc

Poem

🐇 Hop, hop through the UI we go,
Clicking menus high and low,
The ≡ opens, the ⚙ gleams,
Playwright weaves our testing dreams.
Every assertion passed — oh joy!
A smoke test built by this bunny boy. 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Add e2e test that opens the Interlinearizer' is concise and accurately summarizes the main change—adding a new e2e smoke test for the Interlinearizer opening workflow.
Linked Issues check ✅ Passed The PR fully implements the requirements from issue #115: adds a helper function for opening the Interlinearizer, creates a smoke test validating the complete workflow from Scripture Editor through Interlinearizer focus, and verifies the presence of both menu buttons (≡ and ⚙).
Out of Scope Changes check ✅ Passed All changes are directly aligned with the PR objectives: the helper function is a reusable prerequisite, the new smoke test implements the required workflow, and test suite adjustments support the new test integration.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch e2e-open-ext

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@imnasnainaec imnasnainaec changed the title Add e2e test that opens the interlinearizer via Scripture Editor menu Add e2e test that opens the Interlinearizer Jun 19, 2026
@imnasnainaec imnasnainaec marked this pull request as ready for review June 19, 2026 15:45
coderabbitai[bot]

This comment was marked as resolved.

@alex-rawlings-yyc alex-rawlings-yyc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-rawlings-yyc reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).

@imnasnainaec imnasnainaec merged commit 4ee0808 into main Jun 19, 2026
11 checks passed
@imnasnainaec imnasnainaec deleted the e2e-open-ext branch June 19, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add e2e test that opens the interlinearizer

2 participants