Add access information to roads#146
Conversation
This adds access information for car, bicycle, and foot to appropriate features in the streets layer.
|
The issue at the time was osm-carto just rendering access based on the value of the (literal) "access" tag, which led to massive amount of very wrong tagging (I suspect that is for the major part still present). Don't think there is any danger of that here. |
|
cc @shortbread-tiles/steering-committee for vote |
|
Agree this is worth doing, and the approach taken here is very good. Two considerations:
|
My thoughts at the time were that the new bicycle_access was defined differently from bicycle. Thinking about it now it's not a problem for values that map to yes or no as a style handling current access tagging has to handle those. The problem is that a style working with the values that map to limited would break. I'm skeptical about the value of horse access information for a general purpose map. Motor_vehicle, bicycle, and foot are the three most common ways for someone to get around while they need access information. Horse is a much more niche access mode. If we keep horse in 2.0 I think we need to justify why it but not moped, motorcycle, truck, and other access restrictions that are more useful to most people. I don't mind adding it in 1.1. I agree on permissive mapping to yes |
|
Agree on horse - could be dropped from 2.0 and is probably a bit immaterial until then. Our semver policy doesn't explicitly prohibit changing values in a point release. It might fall under the nebulous "forward-compatible" banner, but Shortbread is sufficiently young I think we can allow ourselves a bit of latitude on a small minority of values for one as yet little-used field. So for 1.1 I would suggest we:
|
|
I've changed I'd like feedback from other maintainers about dropping the existing values for somewhat accessible access and replacing it with a new value styles won't know about as well as going from empty string to not present for no access information. I'm okay with this change and being a bit laxer for 1.1 then we would be with 1.2 or 2.1. |
This adds access information for car, bicycle, and foot to appropriate features in the streets layer.
I went with 13+ for access because that's where it's useful. Showing foot and bicycle access is of little value if you're not also showing highway=footway/cycleway/path features.
cc @simonpoole because I know he has strong opinions on mode-specific access information on general purpose maps.
Fixes #38