Fix float-mode build break: add MUL5A_SS / MUL6A_SS fallbacks#764
Merged
Conversation
Collaborator
|
Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds float-mode fallbacks for
MUL5A_SSandMUL6A_SSinsrc/amy_fixedpoint.h.Why
Since 98ea6bc ("Change multiply resolution to help Xanadu"),
oscillators.c:18references
MUL5A_SSunconditionally:But
MUL5A_SSandMUL6A_SSare defined only inside the fixed-point block ofamy_fixedpoint.h. Building withAMY_USE_FIXEDPOINTundefined (the float pathused on FPU targets — desktop, wasm/Emscripten, ESP32-S3, MicroPython) fails:
Fix
Add the same
(a) * (b)fallback that every otherMUL*_SSmacro already hasin the float block:
Notes
#ifndef AMY_USE_FIXEDPOINT, so the defaultfixed-point build is untouched.
without these lines and compiles cleanly with them.