Skip to content

src/patches.c: Don't ignore FX commands when synth is specified (issue #755).#756

Merged
dpwe merged 1 commit into
mainfrom
755_synth_FX
Jun 23, 2026
Merged

src/patches.c: Don't ignore FX commands when synth is specified (issue #755).#756
dpwe merged 1 commit into
mainfrom
755_synth_FX

Conversation

@dpwe

@dpwe dpwe commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Fixes #755

@bwhitman

Copy link
Copy Markdown
Collaborator

🎛️ AMYboard HW CI

Dispatched this PR's amy SHA to the tulipcc bench — it builds the AMYboard firmware with your change and runs it on the physical board (audio spectral-compared to a committed reference). Results post here in a few minutes.

@bwhitman

Copy link
Copy Markdown
Collaborator

🎛️ HW CI (physical bench)

Built from this AMY PR, pinned into the tulipcc amy submodule.

AMYboard (USB-MIDI + AMY zP → audio): ✅ PASS — flashed this PR’s firmware; all checks matched the references.

Tulip (TULIP4_R11; serial-REPL audio + WiFi screenshot): ✅ PASS — flashed this PR’s firmware; all checks matched the references.

⬇️ Artifacts: recordings · screenshot · serial logs · run logs

Self-hosted bench. Audio spectral-compared to ref/hwci_basic.wav + ref/tulip_basic.wav; Tulip screenshot pixel-compared to ref/tulip_screenshot.png. Both analog outs share one capture card, so the tests run sequentially.

@dpwe dpwe merged commit fb6a9b2 into main Jun 23, 2026
9 checks passed
@dpwe dpwe deleted the 755_synth_FX branch June 23, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FX commands are ignored when directed to a synth

2 participants