fix: surface docker compose up failures in devtui#1042
Merged
Conversation
When `docker compose up -d` fails, the captured stderr and "Failed:" message were appended to overlay lines but the view kept rendering the spinning "Starting Docker containers..." card, leaving the user stuck without any error information until they pressed `l`. Force the logs view on when the start command errors so the output is visible immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker compose up -dfailed in devtui, the user was stuck on the spinning "Starting Docker containers..." screen with no error info. The captured stderr andFailed: …line were appended tooverlayLinesbut only rendered whendockerShowLogswas true, which required pressingl.dockerShowLogs = trueon the error path inupdateLifecycleso the docker output and error message are visible immediately.Test plan
go test ./internal/devtui/TestUpdateLifecycle_DockerStarted_ErrorStaysAndRendersErrorthatdockerShowLogsis true after an error