Fix critical error handling and resource management in C++ code#2
Merged
Conversation
- Add nil-check for version regex match with informative error message - Use Shellwords.escape() to safely handle tag names in shell commands - Fix PKG_CONFIG_PATH handling to properly escape paths with special characters - Improves robustness against malformed configuration or injection attacks Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
**Critical Fixes:** - Add null pointer checks in callback for input validation - Check for integer overflow in callback size calculation - Add CURL handle validation after curl_easy_init() - Use std::call_once for thread-safe CURL global initialization - Check curl_easy_perform() return value and report errors - Validate JSON parse errors with HasParseError() - Add null checks for curl_easy_escape() allocations - Remove unused includes and 'using namespace' directives - Add public setTimeout() method for configurable timeouts **Improvements:** - Use std::ostringstream for efficient URL parameter encoding - Replace static bool with std::once_flag for thread safety - Return meaningful error messages on failures - Add exception safety in callback function - Proper cleanup of CURL resources on all error paths Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses critical error handling, resource management, and thread safety issues in the C++ client library. All changes are backwards compatible.
Critical Fixes
Code Quality Improvements
using namespacedirectives (best practice)API Additions
setTimeout(int seconds)method for configurable request timeoutsTest plan
🤖 Generated with Claude Code