Add support for creating SDF structures directly in Microkit tool#542
Draft
sfulham wants to merge 3 commits into
Draft
Add support for creating SDF structures directly in Microkit tool#542sfulham wants to merge 3 commits into
sfulham wants to merge 3 commits into
Conversation
…ation Signed-off-by: Charlotte Fulham <u7917382@anu.edu.au>
…ation Signed-off-by: Charlotte Fulham <u7917382@anu.edu.au>
Signed-off-by: Charlotte Fulham <u7917382@anu.edu.au>
Collaborator
|
Quick comment: these should not duplicate the existing checks in the code, but should replace them / be refactored. |
Author
Yeah that's the plan, just translating the checks into a way that makes most sense for validation without the XML first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #455. Adds
newfunctions for relevant SDF structures, including validation to ensure resulting System Description is valid.