Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: eliminate blocking .get() in HostConnectionPool.initAsync to prevent Netty I/O thread deadlock #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: scylla-3.x
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
fix: eliminate blocking .get() in HostConnectionPool.initAsync to prevent Netty I/O thread deadlock #917
Changes from all commits
d03e34536c2472File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
openAsyncthrows before it can return a future (for exampleconnection.initAsync()can throw while resolving anSniEndPointor during Netty bootstrap setup), this call now escapesHostConnectionPool.initAsyncbecause the oldtry/catchwas removed.replacePoolhas already put the new pool in the map, so that host can be left stuck inINITIALIZINGand session initialization/update can abort instead of completing the pool-init future as a handled failure; keep synchronous exceptions converted to a failedListenableFuture.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also link the original issue in Jira (just to make this less dependent on GitHub): https://scylladb.atlassian.net/browse/SCYLLADB-2324. Same for the previous commit message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This stub only affects the new
openAsyncpath; if the implementation regresses back to the previous blockingopen()call, the spy will invoke the realopen()and may create a normal connection on another Netty I/O thread, so the test can pass instead of exercising the deadlock. To make the regression deterministic, also stub/blockopen(...)or force a single-event-loop group.Uh oh!
There was an error while loading. Please reload this page.