Skip to content

Fixes #298: Repeatedly appending parent path to flatFiles#305

Merged
LucaMarconato merged 4 commits intoscverse:mainfrom
mayank-singh-sikarwar:cosmx_reader
Apr 30, 2026
Merged

Fixes #298: Repeatedly appending parent path to flatFiles#305
LucaMarconato merged 4 commits intoscverse:mainfrom
mayank-singh-sikarwar:cosmx_reader

Conversation

@mayank-singh-sikarwar
Copy link
Copy Markdown
Contributor

@mayank-singh-sikarwar mayank-singh-sikarwar commented Apr 29, 2025

Purpose: Fix for appending parent path to CSV file paths in cosmx.py reader module.

@mayank-singh-sikarwar mayank-singh-sikarwar marked this pull request as draft April 29, 2025 09:58
@mayank-singh-sikarwar mayank-singh-sikarwar marked this pull request as ready for review April 29, 2025 09:59
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 29, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.15%. Comparing base (79e5f89) to head (0fab182).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata_io/readers/cosmx.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   62.15%   62.15%           
=======================================
  Files          27       27           
  Lines        3181     3181           
=======================================
  Hits         1977     1977           
  Misses       1204     1204           
Files with missing lines Coverage Δ
src/spatialdata_io/readers/cosmx.py 18.18% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaMarconato LucaMarconato linked an issue Apr 30, 2026 that may be closed by this pull request
@LucaMarconato LucaMarconato merged commit acf08dc into scverse:main Apr 30, 2026
5 checks passed
@LucaMarconato
Copy link
Copy Markdown
Member

Thanks @mayank-singh-sikarwar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spio.cosmx appends path two times to the file name

3 participants