Skip to content

adjusted docstrings in steinbock reader py file#165

Merged
LucaMarconato merged 4 commits intoscverse:mainfrom
LukasHats:steinbock_reader
Apr 30, 2026
Merged

adjusted docstrings in steinbock reader py file#165
LucaMarconato merged 4 commits intoscverse:mainfrom
LukasHats:steinbock_reader

Conversation

@LukasHats
Copy link
Copy Markdown
Contributor

As discussed in here, I made a few comments in the docstrings of the steinbock reader to improve documentation and possibly also improvements to the code.

Also tagging @melonora here as we will sit together and have a look at how to improve flexibility or at least the documentation.

@melonora melonora marked this pull request as ready for review February 24, 2025 08:33
@melonora melonora closed this Feb 24, 2025
@melonora melonora reopened this Feb 24, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.15%. Comparing base (79e5f89) to head (b534195).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   62.15%   62.15%           
=======================================
  Files          27       27           
  Lines        3181     3181           
=======================================
  Hits         1977     1977           
  Misses       1204     1204           
Files with missing lines Coverage Δ
src/spatialdata_io/readers/steinbock.py 34.69% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

LucaMarconato and others added 2 commits April 30, 2026 14:30
- Move notes into a proper NumPy `Notes` section (fixes RST render)
- Fix typos: andata→anndata, adviced→advised
- Correct adata.obs.images→adata.obs.image (verified from source)
- Replace plain URL with RST hyperlink syntax
- Clarify that only one masks dir is used at a time (controlled by labels_kind)
- Specify *.ome.tiff image format (from SteinbockKeys.IMAGE_SUFFIX)
- Explain the images.csv/--info mechanism with required columns and correct
  link to file types docs instead of preprocessing docs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@LucaMarconato LucaMarconato merged commit 86e789f into scverse:main Apr 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants