fix: PCA centering in ingest#4208
Open
Intron7 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Intron7 <severin.dicks@icloud.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4208 +/- ##
==========================================
+ Coverage 79.91% 79.97% +0.06%
==========================================
Files 121 121
Lines 12949 12953 +4
==========================================
+ Hits 10348 10359 +11
+ Misses 2601 2594 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Intron7 <severin.dicks@icloud.com>
| def fail_toarray(*args, **kwargs) -> None: | ||
| pytest.fail("PCA ingest must not densify the query matrix") | ||
|
|
||
| monkeypatch.setattr(type(adata_new.X), "toarray", fail_toarray) |
Member
There was a problem hiding this comment.
a bit fragile, but I can’t think of a better way …
flying-sheep
approved these changes
Jul 13, 2026
Member
|
just add a relnote |
flying-sheep
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ingest centers its PCA against the query data not the fit data. I also made PCA sparse