✨ S3UTILS-230 implement CRR multi-site V2 replication format#396
Open
DarkIsDude wants to merge 2 commits into
Open
✨ S3UTILS-230 implement CRR multi-site V2 replication format#396DarkIsDude wants to merge 2 commits into
DarkIsDude wants to merge 2 commits into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development/1 #396 +/- ##
=================================================
+ Coverage 44.90% 45.65% +0.75%
=================================================
Files 88 88
Lines 6456 6566 +110
Branches 1352 1378 +26
=================================================
+ Hits 2899 2998 +99
- Misses 3511 3522 +11
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DarkIsDude
commented
May 29, 2026
DarkIsDude
commented
May 29, 2026
DarkIsDude
commented
May 29, 2026
DarkIsDude
commented
May 29, 2026
DarkIsDude
commented
May 29, 2026
d5490b8 to
f9fca0c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReplicationStatusUpdater, implementing the CRR to Multiple Sites designFilter,Priority, orDestination.Account) route through a new_markObjectPendingV2path that writes per-backenddestination/roleand removes legacy top-levelstorageClass/storageType/destinationStorageClassor no V2 indicators) retain existing behavior unchangedChanges
CRR/ReplicationStatusUpdater.js_isLegacyFormat()— detects V1 vs V2 bucket config format_getMatchingRules()— prefix-matches object key against rules, deduplicates by site (highest priority wins)_deriveRuleRole()— substitutesDestination.Accountinto the role ARN to produce per-rule IAM role_computeTopLevelStatus()— aggregates backend statuses: FAILED > PROCESSING > COMPLETED_markObjectPendingV2()— V2 metadata writer (per-backend destination/role, no legacy top-level fields)_markPending()— routes to V1 or V2 path based on bucket config formattests/utils/crr.js— V2 bucket replication config fixturetests/unit/CRR/ReplicationStatusUpdater.js— 7 new V2 test cases (single match, dual-rule prefix overlap, no-match skip, SITE_NAME filter, all-up-to-date skip, PROCESSING aggregate status, forceUsingConfiguration)Test plan
yarn test:unit)yarn lint)destination/roleand no legacy top-level fieldsIssue: S3UTILS-230