Add low-CPU local runtime targets#229
Merged
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Owner
Author
|
Review completed: no blocking findings. The Makefile targets are scoped, Compose port overrides preserve default localhost bindings, env guidance covers DATABASE_URL, DATABASE_ADMIN_URL, and REDIS_URL, and focused validation passed locally plus GitHub checks are green. GitHub does not allow this account to approve its own PR, so this is recorded as a review note before admin merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Makefile targets that match the preview docs: make api for API-only sessions, make runtime for low-CPU API plus next start, and make web-build for explicit web builds. Also allows local Docker Compose host port overrides for Postgres and Redis so Alice can coexist with another local stack. Verification: make -n api; make -n runtime; make -n web-build; env ALICEBOT_POSTGRES_HOST_PORT= ALICEBOT_REDIS_HOST_PORT= docker compose config; env ALICEBOT_POSTGRES_HOST_PORT=15432 ALICEBOT_REDIS_HOST_PORT=16379 docker compose config; env ALICEBOT_POSTGRES_HOST_PORT= ALICEBOT_REDIS_HOST_PORT= docker compose -f docker-compose.lite.yml config; env ALICEBOT_POSTGRES_HOST_PORT=15432 docker compose -f docker-compose.lite.yml config; ./scripts/validate_env.sh .env.example .env.lite.example apps/web/.env.local.example; git diff --check.