Implement introspectable actions#1588
Merged
Merged
Conversation
rytilahti
reviewed
Nov 9, 2022
Contributor
Author
|
@rytilahti done processing feedback, could you have another look/merge? |
Codecov Report
@@ Coverage Diff @@
## master #1588 +/- ##
==========================================
+ Coverage 80.88% 80.91% +0.02%
==========================================
Files 156 156
Lines 15258 15276 +18
Branches 3283 3301 +18
==========================================
+ Hits 12342 12360 +18
Misses 2667 2667
Partials 249 249
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8 tasks
rytilahti
reviewed
Nov 9, 2022
Contributor
Author
|
@rytilahti I think this can be merged. |
Contributor
Author
|
@rytilahti I added the missing actions, could you merge this PR? |
rytilahti
approved these changes
Nov 15, 2022
rytilahti
left a comment
rytilahti
left a comment
Owner
There was a problem hiding this comment.
Tested to work as expected, thanks @starkillerOG! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the last missing introspectable properties (#1495), support for actions and implements them for RoborockVacuum.
The home assistant fork using this information is available at https://github.com/rytilahti/home-assistant/tree/xiaomi_miio/feat/entities_from_upstream
Split out from #1543