feat(link): add support of creating ipvlan and ipvtap.#62
Open
xujunjie-cover wants to merge 1 commit into
Open
feat(link): add support of creating ipvlan and ipvtap.#62xujunjie-cover wants to merge 1 commit into
xujunjie-cover wants to merge 1 commit into
Conversation
cathay4t
requested changes
Jun 24, 2024
cathay4t
left a comment
cathay4t
left a comment
Member
There was a problem hiding this comment.
Considering the ipvlan/ipvtap only has 3 properties link, mode, flags. So please finish the work in single PR by include flags also.
Author
Member
|
ping |
xujunjie-cover
force-pushed
the
ipvlan_and_ipvtap
branch
from
f59979f to
1c1a284
Compare
Author
pong |
xujunjie-cover
force-pushed
the
ipvlan_and_ipvtap
branch
from
1c1a284 to
8bab098
Compare
xujunjie-cover
force-pushed
the
ipvlan_and_ipvtap
branch
from
94a465e to
8d9c283
Compare
xujunjie-cover
force-pushed
the
ipvlan_and_ipvtap
branch
2 times, most recently
from
a4374e1 to
79f852c
Compare
xujunjie-cover
force-pushed
the
ipvlan_and_ipvtap
branch
from
2ebfdfe to
79f852c
Compare
feat: - add support of creating ipvlan and ipvtap - add examples.
xujunjie-cover
force-pushed
the
ipvlan_and_ipvtap
branch
from
79f852c to
13f46ea
Compare
Author
|
help review, thanks @cathay4t |
|
This looks good to me, and it appears @xujunjie-cover has handled the feedback. We would really like to use this new functionality in the product we're building at [insert tech company's name I don't want to say but who laid off 30K people yesterday]. Can we get this merged and released? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: