Skip to content

std: upgrade addr2line, object, miniz_oxide#159345

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
cuviper:std-deps
Jul 15, 2026
Merged

std: upgrade addr2line, object, miniz_oxide#159345
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
cuviper:std-deps

Conversation

@cuviper

@cuviper cuviper commented Jul 15, 2026

Copy link
Copy Markdown
Member

The addr2line upgrade also upgrades gimli, and we need a new
unwinding to align on that. No code changes are required.

See also rust-lang/backtrace-rs#765, but since std uses that as a
#[path] mod backtrace_rs, we don't need to wait for the crate update.

The `addr2line` upgrade also upgrades `gimli`, and we need a new
`unwinding` to align on that. No code changes are required.
@rustbot

This comment has been minimized.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 15, 2026
@rustbot

rustbot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

r? @Darksonn

rustbot has assigned @Darksonn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 13 candidates
  • Random selection from 6 candidates

@Darksonn

Copy link
Copy Markdown
Member

Seems ok to me.

@bors r+

@rust-bors

rust-bors Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 08bda6d has been approved by Darksonn

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 15, 2026
std: upgrade `addr2line`, `object`, `miniz_oxide`

The `addr2line` upgrade also upgrades `gimli`, and we need a new
`unwinding` to align on that. No code changes are required.

See also rust-lang/backtrace-rs#765, but since `std` uses that as a
`#[path] mod backtrace_rs`, we don't need to wait for the crate update.
rust-bors Bot pushed a commit that referenced this pull request Jul 15, 2026
…uwer

Rollup of 2 pull requests

Successful merges:

 - #158764 (Improve E0277 for imperfect derives)
 - #159345 (std: upgrade `addr2line`, `object`, `miniz_oxide`)
rust-bors Bot pushed a commit that referenced this pull request Jul 15, 2026
…uwer

Rollup of 2 pull requests

Successful merges:

 - #158764 (Improve E0277 for imperfect derives)
 - #159345 (std: upgrade `addr2line`, `object`, `miniz_oxide`)
@rust-bors
rust-bors Bot merged commit abc46f4 into rust-lang:main Jul 15, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 15, 2026
rust-timer added a commit that referenced this pull request Jul 15, 2026
Rollup merge of #159345 - cuviper:std-deps, r=Darksonn

std: upgrade `addr2line`, `object`, `miniz_oxide`

The `addr2line` upgrade also upgrades `gimli`, and we need a new
`unwinding` to align on that. No code changes are required.

See also rust-lang/backtrace-rs#765, but since `std` uses that as a
`#[path] mod backtrace_rs`, we don't need to wait for the crate update.
@JonathanBrouwer

Copy link
Copy Markdown
Contributor

@rust-timer build ceadccd

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (ceadccd): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.3% [0.2%, 0.6%] 7
Regressions ❌
(secondary)
0.3% [0.2%, 0.5%] 29
Improvements ✅
(primary)
-0.8% [-0.8%, -0.7%] 4
Improvements ✅
(secondary)
-2.7% [-4.9%, -0.5%] 2
All ❌✅ (primary) -0.1% [-0.8%, 0.6%] 11

Max RSS (memory usage)

Results (primary 3.3%, secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.3% [3.3%, 3.3%] 1
Regressions ❌
(secondary)
5.4% [1.2%, 9.6%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.3% [-4.5%, -4.2%] 2
All ❌✅ (primary) 3.3% [3.3%, 3.3%] 1

Cycles

Results (primary -2.2%, secondary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.5% [2.3%, 4.8%] 2
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
-3.9% [-4.9%, -2.8%] 3
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Binary size

Results (primary -0.4%, secondary -0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.4% [-0.7%, -0.1%] 8
Improvements ✅
(secondary)
-0.7% [-0.7%, -0.6%] 27
All ❌✅ (primary) -0.4% [-0.7%, -0.1%] 8

Bootstrap: 490.55s -> 490.311s (-0.05%)
Artifact size: 390.05 MiB -> 389.46 MiB (-0.15%)

@rustbot rustbot added the perf-regression Performance regression. label Jul 16, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor

That's quite a significant perf regression, any idea what caused it?

@Darksonn

Copy link
Copy Markdown
Member

Yeah, perhaps we should revert?

@JonathanBrouwer

JonathanBrouwer commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Revert posted here: #159373

@Kobzol

Kobzol commented Jul 16, 2026

Copy link
Copy Markdown
Member

There are some small icount doc regressions, but otherwise this looks fine, since it's a dependency upgrade. I don't think that this even needs a revert.

@cuviper

cuviper commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

It's a bit curious that this slowed down, but that could just be that the new dependencies are a little larger, so there's more metadata etc. I don't think it's enough to worry about or revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants