std: upgrade addr2line, object, miniz_oxide#159345
Conversation
The `addr2line` upgrade also upgrades `gimli`, and we need a new `unwinding` to align on that. No code changes are required.
This comment has been minimized.
This comment has been minimized.
|
r? @Darksonn rustbot has assigned @Darksonn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Seems ok to me. @bors r+ |
std: upgrade `addr2line`, `object`, `miniz_oxide` The `addr2line` upgrade also upgrades `gimli`, and we need a new `unwinding` to align on that. No code changes are required. See also rust-lang/backtrace-rs#765, but since `std` uses that as a `#[path] mod backtrace_rs`, we don't need to wait for the crate update.
Rollup merge of #159345 - cuviper:std-deps, r=Darksonn std: upgrade `addr2line`, `object`, `miniz_oxide` The `addr2line` upgrade also upgrades `gimli`, and we need a new `unwinding` to align on that. No code changes are required. See also rust-lang/backtrace-rs#765, but since `std` uses that as a `#[path] mod backtrace_rs`, we don't need to wait for the crate update.
|
@rust-timer build ceadccd |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (ceadccd): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 3.3%, secondary 0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.2%, secondary -0.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.4%, secondary -0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 490.55s -> 490.311s (-0.05%) |
|
That's quite a significant perf regression, any idea what caused it? |
|
Yeah, perhaps we should revert? |
|
Revert posted here: #159373 |
|
There are some small icount doc regressions, but otherwise this looks fine, since it's a dependency upgrade. I don't think that this even needs a revert. |
|
It's a bit curious that this slowed down, but that could just be that the new dependencies are a little larger, so there's more metadata etc. I don't think it's enough to worry about or revert. |
The
addr2lineupgrade also upgradesgimli, and we need a newunwindingto align on that. No code changes are required.See also rust-lang/backtrace-rs#765, but since
stduses that as a#[path] mod backtrace_rs, we don't need to wait for the crate update.