chore(scaffold): run init via @rtcamp/wp-tooling/init#721
Closed
aryanjasala wants to merge 5 commits into
Closed
Conversation
Gates GenerateTailwindThemePlugin (from @rtcamp/wp-tooling) on the entry file src/css/frontend/tailwind.css, guard-requiring wp-tooling so the build still works when it is absent. Dormant until the Tailwind feature creates the entry.
Toggleable in manage mode: copies the entry CSS + PostCSS config and adds the tailwindcss / @tailwindcss/postcss devDeps; detected via the entry file. The build side lives in webpack.config.js.
functions.php now defaults ELEMENTARY_THEME_ENABLE_TAILWIND to false (the scaffold feature flips it); the webpack token plugin is still entry-file gated at build time, and the wp-tooling catch only skips that plugin, not Tailwind compilation.
HMR (BrowserSync live reload) is now a toggleable feature, gated on a single ENABLE_HMR flag in .env.local that both the build and PHP read: - webpack only starts the BrowserSync server when ENABLE_HMR is not off - Assets.php only enqueues the client under the same flag - the scaffold feature flips ENABLE_HMR in .env.local on enable/disable Default is on, so existing setups are unaffected. browser-sync deps stay installed (they are dev-only), so the toggle is a fast local switch. DISABLE_BS still works for the finer client-only case. Toggle from `npm run init` (manage mode) or by editing .env.local directly.
Resolve the init engine from the @rtcamp/wp-tooling npm dependency instead of probing vendor/rtcamp/wp-framework. Drops the Composer vendor path and the fs existence check.
Adi-ty
force-pushed
the
feat/hmr
branch
2 times, most recently
from
0faace2 to
91be41f
Compare
|
This one's content is already folded into #716. We can close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Switches
npm run initto the relocated init engine:require('@rtcamp/wp-tooling/init')instead of probingvendor/rtcamp/wp-framework/bin/scaffold.js. The engine is now an npm dependency, not a Composer vendor path.Changes
bin/init.js— require the engine from@rtcamp/wp-tooling/init; drop the vendor existence check and the now-unusedfsrequire.Blocked on
rtCamp/wp-tooling#32 (the
./initexport) being published + bumping the@rtcamp/wp-toolingversion pin here. Until thennpm run initresolves the engine only via a local link/pack. Draft until published.