Fix pop() corrupting index map when removing non-last element#106
Open
gaoflow wants to merge 1 commit into
Open
Fix pop() corrupting index map when removing non-last element#106gaoflow wants to merge 1 commit into
gaoflow wants to merge 1 commit into
Conversation
pop() with a non-default index removed the element from the items list and the map dict, but did not update the stored indices for every element that shifted down. After pop(0), subsequent map lookups and index() calls would return stale positions, breaking the invariant that items[i] and map[items[i]] always agree. discard() already handled this correctly. The fix rebuilds the map after the removal, keeping items and map consistent. Fixes rspeer#83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83.
After
pop(index)removed an element from the middle of an OrderedSet,the internal index map (
self.map) held stale positions for everyelement that shifted down. For example:
The
discard()method already handled this correctly. This PRbrings
pop()in line withdiscard()by rebuilding the map afterremoval so that
items[i]andmapalways agree.Created under human direction with AI assistance.