feat(setup): install the upstream gh agent skill per agent#9
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an optional post-install step to setup that can install (or update) the upstream cli/cli gh agent skill per selected coding agent, and documents this capability in the README.
Changes:
- Add
gh_skill_available,gh_skill_agent_id, andconfigure_gh_skillhelpers to detect/install/update the upstreamghagent skill. - Run the per-agent
ghskill installation/update step after the main per-tool install loop (gated ongh skillavailability). - Document the new
ghagent skill behavior and manual commands inREADME.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
setup |
Adds per-agent detection + install/update flow for the upstream gh agent skill. |
README.md |
Documents the new optional gh agent skill installation/update behavior and manual management commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add a setup section that installs cli/cli's gh agent skill for each selected agent, or updates it when already present. - Detect installs per agent via gh skill list --agent and update via gh skill update gh --agent "$agent_id". - Document the gh agent skill setup step in README.md.
rlorenzo
force-pushed
the
feat/setup-gh-skill-install
branch
from
189969c to
1c7f1c0
Compare
`gh skill update` has no `--agent` flag ("unknown flag: --agent", exit 1),
so the update path failed every time the gh skill was already installed.
Call `gh skill update gh` (which updates the skill across all hosts, its
documented behavior) and keep the success/failure reporting.
Also make the README removal example agent-agnostic instead of hard-coding a
Claude-specific skills path, pointing to `gh skill list` for the exact path.
Claude-Session: https://claude.ai/code/session_019x6ReGXvRWpC7sF8aum6LR
`gh skill update gh` updates the skill across all hosts, not per-agent, so the update-branch messages no longer say "for <agent>" (and no longer print "Updated" when nothing changed). In the README, make the manual install example explicit with `--agent` and drop the inaccurate "defaults to the current agent" note — non-interactively `gh skill install` defaults to github-copilot, so the agent should be stated. Claude-Session: https://claude.ai/code/session_019x6ReGXvRWpC7sF8aum6LR
Plain `gh skill list` prints skillName/host/scope/source but no filesystem path — the `path` field is JSON-only. Point users at `gh skill list --json skillName,path` so the removal instructions are actually followable. Claude-Session: https://claude.ai/code/session_019x6ReGXvRWpC7sF8aum6LR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
setupnow offers to install the upstreamghagent skill (published bycli/cli) for each selected coding agent, or updates it when already present.configure_gh_skillplusgh_skill_available/gh_skill_agent_idhelpers.gh skill install cli/cli gh --agent <id> --scope usergh skill list --agent):gh skill update ghgh skillbeing available, so an olderghis skipped cleanly instead of erroring.Why
The
ghskill teaches agents to drive the GitHub CLI well (structured output, pagination, repo targeting, search vs. list,gh apifallback). It's an upstream skill, unrelated to the commands this repo ships — purely additive, no collision with the existing installer.Testing
bash -n setupparses cleanly.gh skill update gh) is idempotent ("All skills are up to date").ghv2.95.0).https://claude.ai/code/session_019x6ReGXvRWpC7sF8aum6LR