fix: to support @react-email/render exports across versions in templates#863
Merged
felipefreitag merged 6 commits intoMay 19, 2026
Merged
Conversation
commit: |
gabrielmfern
requested changes
Mar 5, 2026
…ender and update tests accordingly
gabrielmfern
reviewed
Mar 6, 2026
… and asynchronous rendering
…rasync # Conflicts: # src/emails/emails.ts # src/templates/templates.ts
felipefreitag
approved these changes
May 19, 2026
The bug fix only needs templates.ts to use the shared render() helper. The fallback to renderAsync and the extra error path only matter for a hypothetical @react-email/render version that exports renderAsync but not render, which has never shipped.
gabrielmfern
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@react-email/renderdropped renderAsync in v2.0.0.Summary by cubic
Use a shared
renderhelper to render React components in Templates, aligning with@react-email/render’srenderAPI and removing dynamic imports. This simplifies Templates (and Emails) and preserves a clear error when@react-email/renderis missing.renderdirectly; dynamic import and cached renderer removed.@react-email/renderisn’t installed.render(removedrenderAsyncusage).Written for commit a194555. Summary will update on new commits. Review in cubic