fix(preview-server): detect hsl/hsla colors in compatibility checker#3061
Closed
mvanhorn wants to merge 1 commit into
Closed
fix(preview-server): detect hsl/hsla colors in compatibility checker#3061mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
Contributor
|
@mvanhorn is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: f27e60b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
d220d93 to
f27e60b
Compare
Member
|
Apparently we merged another pull request that was basically a copy of this 🙁 #3401. So sorry for that, but I'm going to close this now since we've already merged the other one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The email compatibility checker now flags
hsl()andhsla()color values as unsupported in Microsoft Outlook on Windows.Previously, these color functions were invisible to the checker because caniemail.com does not track hsl/hsla support data. Users would unknowingly use hsl colors that render correctly in the preview but fail silently in Outlook (Word rendering engine).
Fixes #2947
Changes
caniemail-supplemental-data.ts- Contains manually curated support entries forhsl()andhsla()with Outlook Windows marked as unsupported ("n"). Kept separate from the auto-generatedcaniemail-data.tsso entries survive re-runs offill-caniemail-data.mts.check-compatibility.ts- Merges supplemental entries with the caniemail data so the existing CSS function matching logic picks up hsl/hsla automatically.Why a separate file?
The
caniemail-data.tsfile is auto-generated from caniemail.com's API viafill-caniemail-data.mts. Adding entries directly would get wiped on the next refresh. The supplemental file can be removed once caniemail.com adds official hsl/hsla tracking.This contribution was developed with AI assistance (Claude Code).
Summary by cubic
Flags
hsl()andhsla()colors as unsupported in Outlook on Windows in the email compatibility checker to prevent silent rendering failures. Fixes Linear issue #2947 and publishes a patch to@react-email/preview-server.hsl()/hsla()support data and merged it withcaniemailso the existing CSS function detection flags these colors for Outlook on Windows.Written for commit f27e60b. Summary will update on new commits. Review in cubic