Rewatch: print 'Finished compilation' in watch plain_output mode#8372
Merged
jfrolich merged 1 commit intorescript-lang:masterfrom Apr 19, 2026
Merged
Conversation
When stdout isn't a TTY during `rewatch watch`, full rebuilds previously produced no completion message. Emit a plain 'Finished compilation' line so parent processes and non-TTY consumers can observe when a rebuild finishes.
cknitt
approved these changes
Apr 19, 2026
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When stdout isn't a TTY during
rewatch watch, full rebuilds previously produced no completion message. Emit a plainFinished compilationline so parent processes and non-TTY log consumers can observe when a rebuild finishes.Small UX fix split out of #8241.
Test plan
cargo build --release --manifest-path rewatch/Cargo.tomlrewatch watchintocat, trigger a rebuild, confirm the line appears🤖 Generated with Claude Code