Skip to content

Multi Entry Paths#8367

Open
rolandpeelen wants to merge 3 commits intomasterfrom
multi-entry-paths
Open

Multi Entry Paths#8367
rolandpeelen wants to merge 3 commits intomasterfrom
multi-entry-paths

Conversation

@rolandpeelen
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d7ebd03747

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rewatch/src/build/packages.rs
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 19, 2026

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8367

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8367

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8367

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8367

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8367

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8367

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8367

commit: b6b2c64

"$ref": "#/definitions/namespace-spec",
"description": "can be true/false or a customized name"
},
"multi-entry": {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the name "multi-entry", it is pretty unclear what this option does.

Feedback from Codex

"multi-entry" is misleading here. It sounds like “multiple entrypoints” or a bundler feature, while the actual semantic change is module visibility and naming.

It suggests these alternatives:

  • private-file-modules
  • private-lowercase-modules
  • file-private-modules

Maybe the second one is clearest? Any other suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants