[feat] Allow not using hashes in stage and output dirs#3679
Open
vkarak wants to merge 1 commit into
Open
Conversation
- New configuration option `general.stagedir_hashes` and the associated environment variable `RFM_STAGEDIR_HASHES` are introduced. Signed-off-by: Vasileios Karakasis <vkarak@gmail.com>
vkarak
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3679 +/- ##
========================================
Coverage 91.96% 91.96%
========================================
Files 62 62
Lines 13769 13773 +4
========================================
+ Hits 12662 12666 +4
Misses 1107 1107 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
victorusu
reviewed
Jun 11, 2026
| if runtime.get_option('general/0/stagedir_hashes'): | ||
| test_name = self.short_name | ||
| else: | ||
| test_name = self.display_name.replace(' ', '') |
Contributor
There was a problem hiding this comment.
would you consider '_', instead of joining the words?
It seems to me that it would be a bit more readable.
Contributor
Author
There was a problem hiding this comment.
No, because this is primarily meant to "compact" the parameters and it is consistent with the -n option behaviour where you select tests with MyTest%param=1 instead of MyTest %param=1. But actually I could be more precise and do replace(' %', '%') instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
general.stagedir_hashesand the associated environment variableRFM_STAGEDIR_HASHESare introduced.Closes #2670.
NOTE:
Conversely to the suggestion of symlinks in #2670, this PR introduces an on/off toggle to switch on or off the hashes (default is on). The reason is that if we had symlinks additionally to the hashes, then a recursive directory listing would list twice the same files.