[doc] Fix example with authorization_header in the tutorial#3677
Merged
vkarak merged 1 commit intoJun 10, 2026
Merged
Conversation
Contributor
|
Thanks for the fix; could you rebase this PR against |
The call to the authorization header function is done in the implementation at https://github.com/reframe-hpc/reframe/blob/c6a4b9b4a9b48dec0953bbe4222269f293f1b7b2/reframe/core/logging.py#L754 Therefore, `()` must be absent from the configuration file.
sschmittgwdg
force-pushed
the
fix_authorization_header_config_example
branch
from
731ecd1 to
dd47787
Compare
vkarak
requested changes
Jun 4, 2026
Contributor
There was a problem hiding this comment.
Simply changing the target branch is not enough. I've updated the contribution guide with instructions on how to deal with such scenarios:
https://github.com/reframe-hpc/reframe/wiki/Contributing-to-ReFrame#targeting-the-wrong-branch
vkarak
approved these changes
Jun 9, 2026
vkarak
changed the title
authorization_header in the tutorial
auto-merge was automatically disabled
June 9, 2026 22:20
Pull request was closed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3677 +/- ##
=======================================
Coverage 91.93% 91.93%
=======================================
Files 62 62
Lines 13769 13769
=======================================
Hits 12659 12659
Misses 1110 1110 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to the authorization header function is done in the implementation at
reframe/reframe/core/logging.py
Line 754 in c6a4b9b
Therefore,
()must be absent from the configuration file.