Conversation
Contributor
Contributor
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Documentation-only changes with no runtime or security impact; corrects API examples operators may follow.
Overview
Clarifies how Active-Active (CRDB) database settings should be applied via
default_db_configversus per-instancedb_config, and wires that guidance through the REST API,crdb-cli, and planning/memory docs.The CRDB database config reference is restructured into required
default_db_configfields (e.g. sharding,shard_key_regex,tls_mode,module_list), recommended global settings (includingreplication_oom_threshold_percent), and per-instancedb_config(certs,port, mTLS flags). Related pages now link to that reference and explain that updatingdefault_db_configaffects all instances while instancedb_configoverrides defaults.Replication OOM protection instructions in Active-Active planning and memory-limit docs now use
PATCH /v1/crdbs/{crdb_guid}withdefault_db_config.replication_oom_threshold_percentinstead ofPUT /v1/bdbs, so cluster-wide AA tuning is documented correctly. Minor API doc copy edits (PATCH vs updates POST, typo fix) and small CRDB object table formatting updates round out the change.Reviewed by Cursor Bugbot for commit e9ad0d2. Bugbot is set up for automated code reviews on this repo. Configure here.