Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
A major-version bump of the core Redis client can affect connection, protocol, and command behavior across the library and tests; scope is limited to the version pin plus a targeted test connection option.
Overview
Bumps the central
StackExchange.Redispackage reference from 2.13.17 to 3.0.0 inDirectory.Packages.props, so the whole solution picks up the 3.x client.Test infrastructure is adjusted for 3.0 behavior:
EndpointsFixturenow setsAllowAdmin = trueon clonedConfigurationOptionswhen opening shared endpoint connections, with a note thatExecute/ExecuteAsynchandle admin commands more reliably in 3.0. That aligns fixture-created connections with tests that already rely on admin-style commands (e.g.FLUSHALLviaExecuteinAbstractNRedisStackTest).Cosmetic newline-at-EOF fixes only in the touched files.
Reviewed by Cursor Bugbot for commit 6ef036a. Bugbot is set up for automated code reviews on this repo. Configure here.