Bump coil to 3.5.0 and jvmTarget to 11#3052
Open
Luna712 wants to merge 1 commit into
Open
Conversation
This should still work on minSdk 23. A newer version of coil is necessary for Skiko for compose later on:
```
w: Skiko dependencies' versions are incompatible.
io.coil-kt.coil3:coil-core-jvm:3.3.0
\--- org.jetbrains.skiko:skiko:0.9.4.2 -> 0.144.6
This may lead to compilation errors or unexpected behavior at runtime.
Such version mismatch might be caused by dependency constraints in one of the included libraries.
```
I mean in theory we could ignore it but I don't like that runtime warning. Knowing how things have been in the past if runtime issues can happen it probably will and also, Java 8 is way way out of date anyway, and this should still work on all supported devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should still work on minSdk 23. A newer version of coil is necessary for Skiko for compose later on:
I mean in theory we could ignore it but I don't like that runtime warning. Knowing how things have been in the past if runtime issues can happen it probably will and also, Java 8 is way way out of date anyway, and this should still work on all supported devices.