M3u8Helper: make getDecrypted() suspend#3051
Draft
Luna712 wants to merge 1 commit into
Draft
Conversation
|
|
||
| @OptIn(DelicateCryptographyApi::class) | ||
| fun getDecrypted( | ||
| suspend fun getDecrypted( |
Collaborator
There was a problem hiding this comment.
This breaks the ABI, contrary to expectations.
Contributor
Author
There was a problem hiding this comment.
Yes I know and forgot to add a PR description (the whole reason I just opened this PR lol). What I wanted was some opinion on how not to do that while still doing a suspended version of this.
Collaborator
There was a problem hiding this comment.
I know of no good way beyond the standard deprecation method 😕
Contributor
Author
There was a problem hiding this comment.
Okay I will figure something out later then lol. Thanks for the comment though.
Contributor
Author
There was a problem hiding this comment.
I am marking this as a draft until then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.