Rename CryptoJS object to CryptoJSHelper and make methods suspend#3050
Open
Luna712 wants to merge 1 commit into
Open
Rename CryptoJS object to CryptoJSHelper and make methods suspend#3050Luna712 wants to merge 1 commit into
Luna712 wants to merge 1 commit into
Conversation
The main reason for renaming it is to make the methods suspend to use non-blocking cryptography methods, but renaming it also lets it match the file name as well, which I have wanted to do for awhile anyway. For now though, until next stable this does have the unfortunate side effect of causing code duplication. If there is a better way to do it I would be happy to do that also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main reason for renaming it is to make the methods suspend to use non-blocking cryptography methods, but renaming it also lets it match the file name as well, which I have wanted to do for awhile anyway. For now though, until next stable this does have the unfortunate side effect of causing code duplication. If there is a better way to do it I would be happy to do that also.