test: add an IgnoreOnWeb annotation#3034
Open
Luna712 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some things like coroutines, when compiled to JS tests will fail because it is single threaded, and it can't cancel a synchronous operation from a single threaded system. That causes a few tests from #2812 to fail on JS only, rather than splitting the location for the tests per platform, which can make it harder to find, just ignoring the tests would be better. With this we could then just add
@IgnoreOnWebto the tests we don't care about. The actual inwebTestwould later be:and because of
@OptionalExpectation, we don't need to add actual to any other source sets. I decided to do this as a different PR rather than in #2812 because it is kinda different scope after all, and I don't want to drift that scope to much.I also used
Ignore.ktas the file name becauseIgnoreOnWeb.ktwould mean forwebTestit would beIgnoreOnWeb.web.ktwhich just seems a bit odd. Additionally this way if we ever need we could also add more in the same file likeIgnoreOnJvmorIgnoreOnAndroid.