Skip to content

fix: Filterchip breaking input styles#772

Merged
rohanchkrabrty merged 1 commit intomainfrom
worktree-filterchip-fix
May 5, 2026
Merged

fix: Filterchip breaking input styles#772
rohanchkrabrty merged 1 commit intomainfrom
worktree-filterchip-fix

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • FilterChip's text and date inputs were passing className directly, which targeted the inner <input> element instead of the wrapper, breaking the chip's container styles.
  • Add a classNames.container prop to Input so consumers can style the outer wrapper without overriding the input element itself.
  • Update FilterChip to use classNames={{ container: ... }} for both the Input and DatePicker's inputProps, restoring the intended chip layout.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apsara Ready Ready Preview, Comment May 5, 2026 6:00am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 588a0f35-af41-4e48-809d-7972d15121d3

📥 Commits

Reviewing files that changed from the base of the PR and between ec75a0f and 12b364e.

📒 Files selected for processing (2)
  • packages/raystack/components/filter-chip/filter-chip.tsx
  • packages/raystack/components/input/input.tsx

📝 Walkthrough

Walkthrough

The pull request refactors how CSS classnames are passed to components within the FilterChip and Input components. The InputProps interface was extended to accept an optional classNames object with a container property. The Input component was updated to apply this container className to its outer wrapper div. The FilterChip component was modified to pass styling via the new classNames prop structure to both DatePicker and Input components, replacing the previous direct className approach.

Suggested reviewers

  • rsbh
  • paanSinghCoder
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing FilterChip's input styles by addressing how classnames are passed to components.
Description check ✅ Passed The description is directly related to the changeset, explaining the problem, the solution, and the affected components in clear detail.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty changed the title fix(filter-chip): apply container styles via Input classNames fix: Filterchip breaking input styles May 5, 2026
@rohanchkrabrty rohanchkrabrty merged commit 3390ebc into main May 5, 2026
5 checks passed
@rohanchkrabrty rohanchkrabrty deleted the worktree-filterchip-fix branch May 5, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants