-
Notifications
You must be signed in to change notification settings - Fork 70
Port RAPIDS docs from Jekyll to NVIDIA Sphinx theme #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
0b56d47
6853185
75ced39
b9828ac
833aeaf
0df55ef
dc33cc3
0531a34
b4bde80
ad33396
61cb205
4d49de0
32fa1c9
3ffde60
22cd055
6166ae2
c1e649e
2c791cc
9f1e7f6
50032db
3166ccf
03687d0
76ee9c9
41887bb
e6ee6ef
26b7bb9
42f070e
fa046a1
6d8ffae
c03a97a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,13 @@ | ||
| // For format details, see https://aka.ms/devcontainer.json. For config options, see the | ||
| // README at: https://github.com/devcontainers/templates/tree/main/src/jekyll | ||
| // For format details, see https://aka.ms/devcontainer.json. | ||
| { | ||
| "name": "Jekyll", | ||
| // Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile | ||
| "image": "mcr.microsoft.com/devcontainers/jekyll:2-bullseye", | ||
| "features": { | ||
| } | ||
|
|
||
| // Features to add to the dev container. More info: https://containers.dev/features. | ||
| // "features": {}, | ||
|
|
||
| // Use 'forwardPorts' to make a list of ports inside the container available locally. | ||
| // "forwardPorts": [], | ||
|
|
||
| // Uncomment the next line to run commands after the container is created. | ||
| // "postCreateCommand": "jekyll --version" | ||
|
|
||
| // Configure tool-specific properties. | ||
| // "customizations": {}, | ||
|
|
||
| // Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root. | ||
| // "remoteUser": "root" | ||
| "name": "RAPIDS Docs", | ||
| "image": "mcr.microsoft.com/devcontainers/python:3.14-bookworm", | ||
| "forwardPorts": [8000], | ||
| "portsAttributes": { | ||
| "8000": { | ||
| "label": "RAPIDS Docs", | ||
| "onAutoForward": "openPreview" | ||
| } | ||
| }, | ||
| "postCreateCommand": "pipx install uv && uv sync --locked" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,7 @@ | ||
| _site/ | ||
| _sass/ | ||
| .sass-cache/ | ||
| -P/ | ||
| .vscode | ||
| lib_map.json | ||
| .DS_Store | ||
| files-to-customize.txt | ||
| .jekyll-cache | ||
| .jekyll-metadata | ||
| .netlify | ||
|
Comment on lines
-1
to
-11
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are all of these entries being deleted? I strongly suspect you didn't do this part manually, because I doubt we now suddenly do want to check into source control things like Can you please do a manual pass review pass over these? |
||
| /.ruff_cache/ | ||
| /.venv/ | ||
| /_site/ | ||
| /files-to-customize.txt | ||
| /ci/customization/lib_map.json | ||
| __pycache__/ | ||
| node_modules | ||
| rapids-docs-env/ | ||
| *.pyc | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 3.14 |
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new workflow, I think we may as well try to use the latest versions of these actions, to get bugfixes, security fixes, longer timeline until forced update from GitHub Actions support changes (e.g. GHA bumping the minimum Node version) etc.