specify ordering guarantees in LibFlow.flow NatSpec#469
specify ordering guarantees in LibFlow.flow NatSpec#469thedavidmeister wants to merge 1 commit intomainfrom
Conversation
The previous "Guarantees ordering of the transfers" was vague — it didn't say which ordering. The function actually guarantees two distinct orderings: token-class (ERC20 → ERC721 → ERC1155) and within-class (array index order). NatSpec now spells out both so a caller relying on either does not have to read the source. Closes #381. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
LibFlow.flowNatSpec said "Guarantees ordering of the transfers" without naming which ordering. The function actually guarantees two distinct orderings:NatSpec now spells out both so a caller relying on either property doesn't have to read the source.
Closes #381.
Test plan
🤖 Generated with Claude Code