Skip to content

document the safeTransfer self-flow branch in LibFlow.flowERC20 NatSpec#468

Open
thedavidmeister wants to merge 1 commit into
mainfrom
2026-05-07-issue-379-libflow-erc20-natspec
Open

document the safeTransfer self-flow branch in LibFlow.flowERC20 NatSpec#468
thedavidmeister wants to merge 1 commit into
mainfrom
2026-05-07-issue-379-libflow-erc20-natspec

Conversation

@thedavidmeister
Copy link
Copy Markdown
Contributor

Summary

LibFlow.flowERC20 NatSpec only mentioned safeTransferFrom. The implementation also calls safeTransfer when from == address(this) (OZ transferFrom consumes allowance even when from == msg.sender, so the self-flow branch must use safeTransfer instead). NatSpec now states both branches and the reason for the asymmetry.

Closes #379.

Test plan

  • NatSpec-only

🤖 Generated with Claude Code

The NatSpec only mentioned `safeTransferFrom`. The implementation
also calls `safeTransfer` when `from == address(this)` (OZ
`transferFrom` consumes allowance even when `from == msg.sender`).
NatSpec now states both branches and the reason for the asymmetry.

Closes #379.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Warning

Rate limit exceeded

@thedavidmeister has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 19 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f55e2068-fba3-4264-aded-3d9f880927ea

📥 Commits

Reviewing files that changed from the base of the PR and between ceaea3c and 6759cb6.

📒 Files selected for processing (1)
  • src/lib/LibFlow.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-07-issue-379-libflow-erc20-natspec

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister thedavidmeister self-assigned this May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[A23-8] [INFO] LibFlow.flowERC20 NatSpec omits the safeTransfer self-flow branch

1 participant