document the safeTransfer self-flow branch in LibFlow.flowERC20 NatSpec#468
document the safeTransfer self-flow branch in LibFlow.flowERC20 NatSpec#468thedavidmeister wants to merge 1 commit into
Conversation
The NatSpec only mentioned `safeTransferFrom`. The implementation also calls `safeTransfer` when `from == address(this)` (OZ `transferFrom` consumes allowance even when `from == msg.sender`). NatSpec now states both branches and the reason for the asymmetry. Closes #379. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
LibFlow.flowERC20NatSpec only mentionedsafeTransferFrom. The implementation also callssafeTransferwhenfrom == address(this)(OZtransferFromconsumes allowance even whenfrom == msg.sender, so the self-flow branch must usesafeTransferinstead). NatSpec now states both branches and the reason for the asymmetry.Closes #379.
Test plan
🤖 Generated with Claude Code