revert: delete backup-less configs on restore again#200
Closed
quickbeard wants to merge 1 commit into
Closed
Conversation
… them (#196)" This reverts the behavior change from #196, restoring the original delete-on-no-backup mechanism in `restoreKind`. The original reasoning holds: CoDev only skips the backup step when there was nothing to back up in the first place, so a live config with no `*.backup` alongside it is necessarily post-CoDev (CoDev-authored, or recreated by the tool after CoDev wiped it). Deleting it lands the user at "no file", which IS the pre-CoDev state. Keeping the file instead left the user with a config still pointing at the CoDev gateway with a baked-in API key, after `remove` had already revoked the token and wiped ~/.codev-hub — a broken agent rather than a clean one. Restores `deleted-live` as the `RestoreStatus`, `runRestoreOrDelete` in remove.ts, and the sweep's "any non-noop counts as action" tally. Drops `RemoveResult.keptPaths` and the RemoveApp hint that listed kept files, both of which only existed to describe the kept-live state. Conflicts in tests/lib/remove.test.ts and tests/RemoveApp.test.tsx were resolved to keep the newer config paths from #198/#199 (~/.config/codev/codev.json) with the reverted delete semantics. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverts #196, restoring the original delete-on-no-backup mechanism in
restoreKind.When restoring a tool's config to its pre-CoDev state, a live config file with no
*.backupalongside it is deleted again, rather than being left in place.Why
The original reasoning holds up: CoDev only skips the backup step when there was nothing to back up in the first place. So a live config with no backup next to it is necessarily post-CoDev — either CoDev-authored, or recreated by the tool after CoDev wiped it. Deleting it lands the user at "no file", which is the pre-CoDev state.
Keeping the file, as #196 did, had a cost that outweighed the caution:
configureClaudeCodebakes the gateway URL and API key directly intosettings.json, so a kept config keeps pointing the agent at the CoDev gateway — whilerunRemovehas already revoked the token and wiped~/.codev-hub. The user was left with a broken agent rather than a clean one, and the hint framed the necessary cleanup as optional polish.Changes
configure.ts—kept-live→deleted-live; the no-backup branchrmSyncs the live file again.remove.ts—runRestoreOrKeep→runRestoreOrDelete; reportsdeleted N file(s) (no backup). DropsStepResult.keptPaths/RemoveResult.keptPaths.restore.ts— sweep printsNo backup at <backup>.and counts any non-noopresult as action again.RemoveApp— drops the kept-files hint (it only existed to describe the kept-live state).AGENTS.mdand tests updated to match.Conflict resolution
The revert conflicted with #198/#199, which renamed CoDev Code's config path. Resolved by keeping the newer paths (
~/.config/codev/codev.json) with the reverted delete semantics — the revert is scoped to behavior, not to the path renames.Validation
pnpm fix,pnpm typecheck,pnpm test(910 passed), andpnpm build && node dist/index.js --versionall pass.Also verified end-to-end by driving the built bundle against a throwaway
$HOME:~/.codex/config.toml→ deleted, exit 0.~/.claude/settings.jsonwith a backup → restored to the original contents, backup consumed.Note (not addressed here)
AGENTS.mdline 115 still claimsrunRestore"treats a missing backup as an error and exits 1". That's been stale since #123 —runRestoreunconditionally returns 0 today. Left alone to keep this revert scoped; worth a separate fix.🤖 Generated with Claude Code